Fix bug in datapipeline definition serializer #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a pipeline definition file, if a value is a list, then we need to create individual elements (of the same key) for each element in the list. Otherwise we get a botocore validation error as we're trying to send an invalid request.
|
LGTM. |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Removed Item Group to include DotNetCliToolReference in project file in favor of .NET Core Global Tools for AWS. Updated packages Amazon.Lambda.APIGatewayEvents and Amazon.Lambda.Serialization.Json to latest versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for list values in def->api translation
In a pipeline definition file, if a value is a list, then
we need to create individual elements (of the same key) for
each element in the list. Otherwise we get a botocore validation
error as we're trying to send an invalid request.